linux-mips
[Top] [All Lists]

Re: [patch] cmdline.c rewrite

To: Guido Guenther <agx@sigxcpu.org>, linux-mips@linux-mips.org
Subject: Re: [patch] cmdline.c rewrite
From: Andrew Clausen <clausen@melbourne.sgi.com>
Date: Wed, 5 Feb 2003 11:19:11 +1100
In-reply-to: <20030205000734.GA16674@bogon.ms20.nix>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030204061323.GA27302@pureza.melbourne.sgi.com> <20030204092417.GR16674@bogon.ms20.nix> <20030204223930.GD27302@pureza.melbourne.sgi.com> <20030204231203.GY16674@bogon.ms20.nix> <20030204231909.GE27302@pureza.melbourne.sgi.com> <20030204234529.GZ16674@bogon.ms20.nix> <20030204235543.GG27302@pureza.melbourne.sgi.com> <20030205000734.GA16674@bogon.ms20.nix>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4i
On Wed, Feb 05, 2003 at 01:07:35AM +0100, Guido Guenther wrote:
> On IP22 the PROM uses SystemPartition to find the kernel/bootloader.
> We set it to something like scsi(0)disk(1)rdisk(0)partition(8) to grab
> it from the vh. Is SystemPartition used differently on IP27?

I think SystemPartition is ignored (haven't been able to see any
evidence to the contrary... I should look in the source...)

> [..snip..]
> > So, we should obviously support OSLoadPartition=/dev/sda1 (=> 
> > root=/dev/sda1),
> > but it would also be nice to support OSLoadPartition=dksc(0,1,3).
> Well we could either check if OSLoadPartition matches the linux device
> naming scheme or the other way around and see if it looks like a valid
> device identifier used by the PROM (I'd prefer the later, though) - or
> simply make the OSLoadPartition <-> root= mapping '#ifdef CONFIG_SGI_IP22'.

I think the middle option (the one you prefer) of matching dksc(0,1,3)
and converting it /dev/sda2 is best.  Just, it has to happen after the
hard disks are probed - /dev/sdXY are allocated dynamically (in
a predictable-for-end-user way), so you need to find out what it was
allocated to.  Is this doable in a nice way?

BTW, I think file system labels are a much better way of identifying FSs.

Perhaps this discussion is irrelevant... people who are using
OSLoadPartition to control their bootloader should just add a root=
option.

Cheers,
Andrew


<Prev in Thread] Current Thread [Next in Thread>