linux-mips
[Top] [All Lists]

Re: sigset_t32 broken?

To: Vivien Chappelier <vivienc@nerim.net>
Subject: Re: sigset_t32 broken?
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 27 Jan 2003 10:19:26 +0100 (MET)
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.LNX.4.21.0301270135210.3253-100000@melkor>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Mon, 27 Jan 2003, Vivien Chappelier wrote:

> On Fri, 24 Jan 2003, Ralf Baechle wrote:
> > Most of what your patch does is undoing an accidental commit of a signal
> > rework that wasn't yet supposed to go out.
> 
> Maybe.. but current version is still wrong :) The type of the sig
> array in the 32-bit compatibility struct sigset_t32 must be 32bit long,
> i.e. unsigned int not unsigned long.
> And I think unsigned describes the data better than signed, but that's a
> matter of taste :) (coherent with the choice in asm-mips/signal.h).

Why not make it u32?

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds


<Prev in Thread] Current Thread [Next in Thread>