linux-mips
[Top] [All Lists]

Re: sigset_t32 broken?

To: Vivien Chappelier <vivienc@nerim.net>
Subject: Re: sigset_t32 broken?
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 24 Jan 2003 02:48:54 +0100
Cc: Andrew Clausen <clausen@melbourne.sgi.com>, linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.21.0301231044270.22634-100000@melkor>; from vivienc@nerim.net on Thu, Jan 23, 2003 at 10:59:29AM +0100
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030123071753.GA996@pureza.melbourne.sgi.com> <Pine.LNX.4.21.0301231044270.22634-100000@melkor>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Thu, Jan 23, 2003 at 10:59:29AM +0100, Vivien Chappelier wrote:

> > Shouldn't those two long's be replaced with u64 and u32
> > respectively?  Is the second struct really meant to be twice the
> > size the first?
> 
> They should be the same size, otherwise sys32_rt_sigsuspend and
> sys32_rt_sigaction will return EINVAL. As the comment says:
> /* XXX: Don't preclude handling different sized sigset_t's.  */
> 
> I've posted a patch to fix that earlier this month (Monday 13 Jan
> 2003 "[2.5 PATCH] signal handling").

Most of what your patch does is undoing an accidental commit of a signal
rework that wasn't yet supposed to go out.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>