| To: | Juan Quintela <quintela@mandrakesoft.com> |
|---|---|
| Subject: | Re: [PATCH]: fix possible buffer overflow problem in promlib |
| From: | Geert Uytterhoeven <geert@linux-m68k.org> |
| Date: | Thu, 2 Jan 2003 20:47:49 +0100 (MET) |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, mipslist <linux-mips@linux-mips.org> |
| In-reply-to: | <m2hecrbb3p.fsf@demo.mitica> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
On 2 Jan 2003, Juan Quintela wrote:
> as the issue about prom.h is still not clear, please aply the
> trivial part.
> void prom_printf(char *fmt, ...)
> {
> va_list args;
> - char ppbuf[1024];
> + char ppbuf[BUFSIZE];
What about making ppbuf static, to reduce stack usage?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH]: fix possible buffer overflow problem in promlib, Juan Quintela |
|---|---|
| Next by Date: | unaligned handler problem, Pete Popov |
| Previous by Thread: | [PATCH]: fix possible buffer overflow problem in promlib, Juan Quintela |
| Next by Thread: | Re: [PATCH]: fix possible buffer overflow problem in promlib, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |