linux-mips
[Top] [All Lists]

[PATCH]: test_bit returns int in all the architectures

To: Ralf Baechle <ralf@linux-mips.org>, mipslist <linux-mips@linux-mips.org>
Subject: [PATCH]: test_bit returns int in all the architectures
From: Juan Quintela <quintela@mandrakesoft.com>
Date: 20 Dec 2002 11:20:02 +0100
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Hi
        to be consistent with everybody else, test_bit should return a
        int.  Notice that it only returns 0/1, not a big deal.

Later, Juan.

Index: include/asm-mips64/bitops.h
===================================================================
RCS file: /home/cvs/linux/include/asm-mips64/bitops.h,v
retrieving revision 1.15.2.10
diff -u -r1.15.2.10 bitops.h
--- include/asm-mips64/bitops.h 5 Dec 2002 03:25:20 -0000       1.15.2.10
+++ include/asm-mips64/bitops.h 20 Dec 2002 09:55:13 -0000
@@ -302,7 +302,7 @@
  * @nr: bit number to test
  * @addr: Address to start counting from
  */
-static inline unsigned long test_bit(int nr, volatile void * addr)
+static inline unsigned int test_bit(int nr, volatile void * addr)
 {
        return 1UL & (((volatile unsigned long *) addr)[nr >> 6] >> (nr & 
0x3f));
 }


-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

<Prev in Thread] Current Thread [Next in Thread>