linux-mips
[Top] [All Lists]

Re: [PATCH]: remove warnings on promlib

To: Juan Quintela <quintela@mandrakesoft.com>
Subject: Re: [PATCH]: remove warnings on promlib
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 19 Dec 2002 13:04:05 +0100 (MET)
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <m2r8cemhxt.fsf@demo.mitica>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On 19 Dec 2002, Juan Quintela wrote:

> Something like that?

 Sure.

> Once there, s/vsprintf/vsnprintf/.
> 
> If anybody calls prom_printf with more than 1024 chars, we were b0rked
> :((

 And thanks for fixing this.

> I didn't did the changes for the other users of prom_* that was using 
> asm/sgialib.h, but change is trivial.

 Well, it's usually quite easy to do such stuff to offload maintainers of
the respective files.  And sometimes there are ones that lack an active
maintainer but "just work".  Alternatively, <asm/sgialib.h> itself might
include <asm/prom.h> to ease the transition. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>