linux-mips
[Top] [All Lists]

Re: [PATCH]: make highmem only things enclosed in the right #ifdef

To: Juan Quintela <quintela@mandrakesoft.com>
Subject: Re: [PATCH]: make highmem only things enclosed in the right #ifdef
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 19 Dec 2002 12:59:43 +0100 (MET)
Cc: linux mips mailing list <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <m2znr2mieg.fsf@demo.mitica>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On 19 Dec 2002, Juan Quintela wrote:

> What do you think of this new one?

 Well, you could remove the line below:

>                sizeof(pgd_t ) * USER_PTRS_PER_PGD);
>  
> -     pgd_base = swapper_pg_dir;
>  
>  #ifdef CONFIG_HIGHMEM

but that's nitpicking (and I may fix it up if Ralf applies the patch as
is) -- I've pointed you out the problem of spacing more to bring your
attention to such details than to object this particular change.  The
patch looks semantically OK. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>