linux-mips
[Top] [All Lists]

Re: [PATCH]: c-r4k.c, new gcc's don't like empty labels

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH]: c-r4k.c, new gcc's don't like empty labels
From: Juan Quintela <quintela@mandrakesoft.com>
Date: 18 Dec 2002 23:19:24 +0100
Cc: linux mips mailing list <linux-mips@linux-mips.org>
In-reply-to: <20021218225715.A32351@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <m2bs3kqez8.fsf@demo.mitica> <20021218225715.A32351@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.92
>>>>> "ralf" == Ralf Baechle <ralf@linux-mips.org> writes:

ralf> On Wed, Dec 18, 2002 at 02:43:07AM +0100, Juan Quintela wrote:
>> patch is trivial to eliminate warnings from the compiler

ralf> And yet I didn't like it.  The new syntax requirement isn't only ugly 
code,
ralf> it's harder to read than a replacing the gotos with a simple return ...

I thought that the gotos to end was there for generation of code
reasons.

It is not good in the first place to have labels called out :(

Later, Juan.


-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

<Prev in Thread] Current Thread [Next in Thread>