[Top] [All Lists]

Re: [PATCH]: fix compiler warnings in the math-emulator

To: "Maciej W. Rozycki" <>
Subject: Re: [PATCH]: fix compiler warnings in the math-emulator
From: Juan Quintela <>
Date: 18 Dec 2002 18:51:43 +0100
Cc: linux mips mailing list <>, Ralf Baechle <>
In-reply-to: <>
Original-recipient: rfc822;
References: <>
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.92
>>>>> "maciej" == Maciej W Rozycki <> writes:

maciej> On 18 Dec 2002, Juan Quintela wrote:
>> this patch does:
>> * redefine SETCX to only set cx
>> * define a new macre SETANDTESTCX for the few cases when we also want to
>> test the value set.

maciej> Is it needed?  The part that returns .mx should be optimized away by the
maciej> compiler automagically if unused. 

Idea was to make things compile without warnings, that way when you
change anything, you search for warnings :(

With the changes that I sent, I have put the warnings levels down to
(for IP22) to:
     - 7 C warnings
     - 2 Asm warnings

And some of the remaining warnings are printk(), where we mix ints &
longs all around (no problem if the code is not the same than in 64
bits, otherwise, problem :(

Later, Juan.

In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

<Prev in Thread] Current Thread [Next in Thread>