linux-mips
[Top] [All Lists]

Re: [PATCH]: make highmem only things enclosed in the right #ifdef

To: Juan Quintela <quintela@mandrakesoft.com>
Subject: Re: [PATCH]: make highmem only things enclosed in the right #ifdef
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Wed, 18 Dec 2002 17:35:26 +0100 (MET)
Cc: linux mips mailing list <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <m2k7i8qezg.fsf@demo.mitica>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
On 18 Dec 2002, Juan Quintela wrote:

> +#ifdef CONFIG_HIGHMEM
>       unsigned long vaddr;
> -     pgd_t *pgd, *pgd_base;
>       pmd_t *pmd;
>       pte_t *pte;
> -
> +     pgd_t *pgd, pgd_base;
> +#endif
>       /* Initialize the entire pgd.  */
>       pgd_init((unsigned long)swapper_pg_dir);

 Please don't change the spacing this way -- it worsens readability. 
Check other pathes for cases like this, too. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>