linux-mips
[Top] [All Lists]

Re: O2 VICE support

To: ilya@theIlya.com
Subject: Re: O2 VICE support
From: Christoph Hellwig <hch@infradead.org>
Date: Wed, 11 Dec 2002 22:45:07 +0000
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20021211221629.GP609@gateway.total-knowledge.com>; from ilya@theIlya.com on Wed, Dec 11, 2002 at 02:16:29PM -0800
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20021210191120.GE609@gateway.total-knowledge.com> <20021211133831.A19300@infradead.org> <20021211221629.GP609@gateway.total-knowledge.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Wed, Dec 11, 2002 at 02:16:29PM -0800, ilya@theIlya.com wrote:
> > > +    if (!filp->private_data) {
> > > + filp->private_data = vice_device;
> > > +    }
> > 
> > filp->private_data can't be set.
> ???
> I can live without using it of course, since it isn't currently possible to 
> have
> more then one instance of VICE in same machine, but theoretical possibility 
> does
> exist. Where should I pass information about which specific device current
> call is?

Sorry if that sentence was confusing.  I meant it can't be already set in
->open so the if is superflous.

> > > +void vice_cleanup_module(void)
> > > +{
> > > +#ifndef CONFIG_DEVFS_FS
> > > +    /* cleanup_module is never called if registering failed */
> > > +    unregister_chrdev(vice_major, "vice");
> > > +#endif
> > 
> > Umm, just because someone makes the mistake of enabling devfs he
> > doesn't have to use it.. :)
> I'm not buying that one :)

You can have CONFIG_DEVFS_FS set but devfs not mounted and used.
Thus #ifndef CONFIG_DEVFS_FS code is a very bad idea.


<Prev in Thread] Current Thread [Next in Thread>