linux-mips
[Top] [All Lists]

Re: Malta board patch

To: Jun Sun <jsun@mvista.com>
Subject: Re: Malta board patch
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Wed, 11 Dec 2002 18:27:13 +0100 (MET)
Cc: Carsten Langgaard <carstenl@mips.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <20021211090405.B6755@mvista.com>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Wed, 11 Dec 2002, Jun Sun wrote:

> >             irq = *(volatile u32 *)(KSEG1ADDR(BONITO_PCICFG_BASE));
> > +           __asm__ __volatile__(
> > +                   ".set\tnoreorder\n\t"
> > +                   ".set\tnoat\n\t"
> > +                   "sync\n\t"
> > +                   ".set\tat\n\t"
> > +                   ".set\treorder");
> >             irq &= 0xff;
> >             BONITO_PCIMAP_CFG = 0;
> >             break;
> 
> Would a higher level macro such as __sync or fast_mb be better here?

 Fixed by Ralf in the CVS already. :-)

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>