linux-mips
[Top] [All Lists]

Re: GDB patch

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: GDB patch
From: Daniel Jacobowitz <dan@debian.org>
Date: Tue, 10 Dec 2002 11:51:33 -0500
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <3DF5D902.22E5AA55@mips.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <3DF5D902.22E5AA55@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.1i
On Tue, Dec 10, 2002 at 01:07:31PM +0100, Carsten Langgaard wrote:
> I've attached a patch for gdb-stub.c to make it work better with the
> sde-gdb.
> These changes should be backwards compatible with a standard gdb, so it
> shouldn't break anything.
> Ralf, could you please apply it.

Strongly object.  While I didn't check the implementation, it's nice to
see 'X' implemented.  And P.  But what the heck is this?

> @@ -816,13 +839,64 @@
>               case 'k' :
>                       break;          /* do nothing */
>  
> +             case 'R':
> +                     /* RNN[:SS],    Set the value of CPU register NN (size 
> SS) */
> +                     /* FALL THROUGH */

> -             /*
> -              * Reset the whole machine (FIXME: system dependent)
> -              */
>               case 'r':
> -                     break;
> +                     /* rNN[:SS]     Return the value of CPU register NN 
> (size SS) */


We're not making up a protocol here, we're implementing one.  R and r
don't have anything to do with setting registers.

> +             case 'D':
> +                     putpacket("OK");
> +                     return;
> +                     /* NOTREACHED */
>  
>               /*
>                * Step to next instruction

'D' should generally resume the machine, by the way.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

<Prev in Thread] Current Thread [Next in Thread>