On Mon, 25 Nov 2002, Ralf Baechle wrote:
> Below are patches to replace cli/sti and accomplices from the WD33c93
> driver. Who is currently the maintainer of this driver? Ok to send to
> Linus?
Feel free to send it to Linus. Meanwhile I'll check it in in the m68k tree.
> 2.5 doesn't boot on MIPS yet so this patch is untested. This patch gets
> it to build; it was written by Marc Zygnier and reviewed by me and we
> think it does the right thing.
To me it looks OK as well. Unfortunately I don't have wd33c93 hardware (except
in the old A500/A590, which doesn't run uClinux well/yet :-).
BTW, am I correct in assuming that the driver is broken on 2.4.x as well?
It looks like there are lots of paths in wd33c93_intr() where interrupts aren't
properly restored.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
|