linux-mips
[Top] [All Lists]

Re: cli/sti removal from wd33c93.c

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: cli/sti removal from wd33c93.c
From: Marc Zyngier <mzyngier@freesurf.fr>
Date: 26 Nov 2002 13:52:52 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux/m68k <linux-m68k@lists.linux-m68k.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.4.21.0211261340040.18990-100000@vervain.sonytel.be>
Organization: Metropolis -- Nowhere
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.GSO.4.21.0211261340040.18990-100000@vervain.sonytel.be>
Reply-to: mzyngier@freesurf.fr
Sender: linux-mips-bounce@linux-mips.org
>>>>> "Geert" == Geert Uytterhoeven <geert@linux-m68k.org> writes:

Geert> BTW, am I correct in assuming that the driver is broken on
Geert> 2.4.x as well?  It looks like there are lots of paths in
Geert> wd33c93_intr() where interrupts aren't properly restored.

Indeed, it looks like being (very) broken. Although it has never
failed on my Indigo-2. Maybe interrupts get restored by luck, or these
paths are never taken...

I'll make a 2.4 patch when I'll have some time...

        M.
-- 
Places change, faces change. Life is so very strange.

<Prev in Thread] Current Thread [Next in Thread>