linux-mips
[Top] [All Lists]

Re: [RFT] DEC SCSI driver clean-up

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [RFT] DEC SCSI driver clean-up
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 21 Nov 2002 15:32:04 +0100 (MET)
Cc: Linux/MIPS Development <linux-mips@linux-mips.org>, Linux/m68k <linux-m68k@lists.linux-m68k.org>
In-reply-to: <Pine.GSO.4.21.0211211422360.18129-100000@vervain.sonytel.be>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Thu, 21 Nov 2002, Geert Uytterhoeven wrote:

> On Thu, 21 Nov 2002, Maciej W. Rozycki wrote:
> >  Following is a patch that removes SCp.have_data_in references -- the
> > member is initialized by the NCR53C9x.c core and by the dec_esp.c
> > front-end, but used by neither.  I believe it's some leftover cruft from
> > the days there were no front-ends -- it's actually used by esp.c.  There
> > are a few less significant clean-ups here and there as well. 
> 
> BTW, it's also used by jazz_esp, oktagon_esp, and sun3_exp (the last 2 are
> m68k).

 Yes, I know.  Of these jazz_esp.c and sun3x_esp.c actually make use of
SCp.have_data_in and properly initialize it.  OTOH, oktagon_esp.c
initializes the field similarly to the NCR53C9x.c core, but it doesn't use
it afterwards at all and should be fixed similarly.

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>