linux-mips
[Top] [All Lists]

Re: BUG in the PCNET32 ethernet driver

To: Jeff Garzik <jgarzik@pobox.com>
Subject: Re: BUG in the PCNET32 ethernet driver
From: Carsten Langgaard <carstenl@mips.com>
Date: Wed, 13 Nov 2002 21:08:08 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, tsbogend@alpha.franken.de, linux-net@vger.kernel.org, kevink@mips.com
Organization: MIPS Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <3DD254F8.14DE20EA@mips.com> <3DD280FB.7070907@pobox.com>
Sender: linux-mips-bounce@linux-mips.org
Jeff Garzik wrote:

> Carsten Langgaard wrote:
>
> > @@ -1316,13 +1316,13 @@
> >                   if ((newskb = dev_alloc_skb (PKT_BUF_SZ))) {
> >                       skb_reserve (newskb, 2);
> >                       skb = lp->rx_skbuff[entry];
> > -                     pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], 
> > skb->len,
> > PCI_DMA_FROMDEVICE);
> > +                     pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], 
> > pkt_len +2,
> > PCI_DMA_FROMDEVICE);
> >                       skb_put (skb, pkt_len);
> >                       lp->rx_skbuff[entry] = newskb;
>
> Why does this line not reference PKT_BUF_SZ when all the others do?

In this case we know the size of the packet and therefore only need to handle 
that.
In the other cases we don't know have big the receiving packet is going to be, 
so we has to
take care of the whole buffer.

/Carsten



<Prev in Thread] Current Thread [Next in Thread>