| To: | Kip Walker <kwalker@broadcom.com> |
|---|---|
| Subject: | Re: 64-bit little endian semaphore bug |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Sat, 9 Nov 2002 20:42:13 +0100 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <3DCC4AC2.EC7BD4E1@broadcom.com>; from kwalker@broadcom.com on Fri, Nov 08, 2002 at 03:37:38PM -0800 |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <3DCC4AC2.EC7BD4E1@broadcom.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.2.5.1i |
On Fri, Nov 08, 2002 at 03:37:38PM -0800, Kip Walker wrote: > In the 64-bit kernel, the semaphore structure (like the 32-bit kernel) > has waking and count fields swizzled so they line up the same in a > 64-bit double word for either endian. However, the semaphore-helper.h > function waking_non_zero_interruptible still has specialized code for > little-endian manipulation of the fields as though they are swapped. > > Patch is attached, and fixes a pipe deadlock I was seeing (both the > reader and writer were down'ing the semaphore). > > patch is against 2.5, but should be clean against 2.4 also. Patch is ok. I tweaked it slightly to make the 2.4 and 2.5 versions identical. General request to everybody - cc me on all patches that you wish to submit even if you're posting them to some list. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | 64-bit little endian semaphore bug, Kip Walker |
|---|---|
| Next by Date: | [PATCH 2.4] explicit R5000 cpu controlled secondary cache support fix, Brian Murphy |
| Previous by Thread: | 64-bit little endian semaphore bug, Kip Walker |
| Next by Thread: | [PATCH 2.4] explicit R5000 cpu controlled secondary cache support fix, Brian Murphy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |