linux-mips
[Top] [All Lists]

Re: fixed the problem about build of vr41xx on linux-2.5.45

To: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
Subject: Re: fixed the problem about build of vr41xx on linux-2.5.45
From: Ralf Baechle <ralf@uni-koblenz.de>
Date: Sun, 3 Nov 2002 18:36:50 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20021103235224.2d7a4814.yuasa@hh.iij4u.or.jp>; from yuasa@hh.iij4u.or.jp on Sun, Nov 03, 2002 at 11:52:24PM +0900
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20021103235224.2d7a4814.yuasa@hh.iij4u.or.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Sun, Nov 03, 2002 at 11:52:24PM +0900, Yoichi Yuasa wrote:

> Hello Ralf,
> 
> I fixed the problem about build of vr41xx on linux-2.5.45.
> Here is a patch.

I applied the patch although quite heavily modified.  Here the bad bits:

>  config SERIAL
>       tristate
> -     depends on NEC_OSPREY || IBM_WORKPAD || CASIO_E55
> +     depends on ZAO_CAPCELLA || NEC_EAGLE || NEC_OSPREY || VICTOR_MPC30X || 
> IBM_WORKPAD || CASIO_E55
>       default y
>       ---help---
>         This selects whether you want to include the driver for the standard

This misses the problem.  There is no more CONFIG_SERIAL option and as such
I removed all CONFIG_SERIAL* stuff entirely.

> @@ -553,9 +553,9 @@
>       depends on MIPS_PB1500 || MIPS_PB1100 || MIPS_PB1000
>       default y
>  
> -config CONFIG_VR41XX_COMMON
> +config VR41XX_COMMON
>       bool
> -     depends on CONFIG_NEC_EAGLE || CONFIG_ZAO_CAPCELLA || 
> CONFIG_VICTOR_MPC30X || CONFIG_IBM_WORKPAD || CONFIG_CASIO_E55
> +     depends on NEC_EAGLE || ZAO_CAPCELLA || VICTOR_MPC30X || IBM_WORKPAD || 
> CASIO_E55
>       default y

And this one entirely misses the code of the problem.  There were a whole
bunch of options which accidently still had the CONFIG_ prefix.

> diff -aruN linux.orig/arch/mips/defconfig-workpad 
> linux/arch/mips/defconfig-workpad
> --- linux.orig/arch/mips/defconfig-workpad    Sun Nov  3 20:43:06 2002
> +++ linux/arch/mips/defconfig-workpad Sun Nov  3 23:36:58 2002
> @@ -22,7 +22,7 @@
>  # Loadable module support
>  #
>  CONFIG_MODULES=y
> -CONFIG_MODVERSIONS=y
> +# CONFIG_MODVERSIONS is not set

It's your call - but as this help to avoid accidents it's a bad idea to
disable CONFIG_MODVERSIONS.

> diff -aruN linux.orig/include/asm-mips/ide.h linux/include/asm-mips/ide.h
> --- linux.orig/include/asm-mips/ide.h Thu Oct 31 22:50:01 2002
> +++ linux/include/asm-mips/ide.h      Sun Nov  3 22:33:12 2002
> @@ -202,8 +202,6 @@
>  
>  #else /* defined(CONFIG_SWAP_IO_SPACE) && defined(__MIPSEB__)  */
>  
> -#define ide_fix_driveid(id)          do {} while (0)
> -

Again this entirely misses the scope of the problem.  There should be no
more definition of ide_fix_driveid() in this file at all and there's
quite a bit more of obsoleted junk left in that file.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>