linux-mips
[Top] [All Lists]

Re: CVS Update@ftp.linux-mips.org: linux

To: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: CVS Update@ftp.linux-mips.org: linux
From: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Date: Thu, 03 Oct 2002 12:17:05 +0900 (JST)
In-reply-to: <20020930165347Z1122169-9213+249@linux-mips.org>
Organization: TOSHIBA Personal Computer System Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20020930165347Z1122169-9213+249@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On Mon, 30 Sep 2002 18:53:47 +0200, ralf@linux-mips.org said:
> Log message:
>       More cache code cleanup.

This commit contains following change.  It seems 'addr' argument is
not used.  Isn't this a mistake?

> @@ -123,15 +72,14 @@ static inline void protected_flush_icach
>       __asm__ __volatile__(
>               ".set noreorder\n\t"
>               ".set mips3\n"
> -             "1:\tcache %1,(%0)\n"
> +             "1:\tcache %0,(%1)\n"
>               "2:\t.set mips0\n\t"
>               ".set reorder\n\t"
>               ".section\t__ex_table,\"a\"\n\t"
>               STR(PTR)"\t1b,2b\n\t"
>               ".previous"
>               :
> -             : "r" (addr),
> -               "i" (Hit_Invalidate_I));
> +             : "i" (Hit_Invalidate_I), "i" (Hit_Invalidate_I));
>  }

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>