linux-mips
[Top] [All Lists]

Re: CVS Update@ftp.linux-mips.org: linux

To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Subject: Re: CVS Update@ftp.linux-mips.org: linux
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 30 Sep 2002 08:24:43 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20020930.135717.39150888.nemoto@toshiba-tops.co.jp>; from nemoto@toshiba-tops.co.jp on Mon, Sep 30, 2002 at 01:57:17PM +0900
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20020929014920Z1121744-9213+239@linux-mips.org> <20020930.135717.39150888.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Mon, Sep 30, 2002 at 01:57:17PM +0900, Atsushi Nemoto wrote:

> It seems some necessary codes for non-r4k CPUs were lost by this change.

Mercyfully sent to /dev/null you wanted to say.

> +     case CPU_SB1:
> +             /*
> +              * XXX - This should be folded in to the "cleaner" handling,
> +              * above
> +              */
> +             memcpy((void *)(KSEG0 + 0x180), &except_vec3_r4000, 0x80);
> +             break;

This was a bug. Except_vec3_r4000 is only intended for the R4000/R4400, the
only MIPS CPUs which support the virtual coherency exception.  SB1 should
use except_vec4_generic instead.

> +     case CPU_TX39XX:
> +             memcpy((void *)(KSEG0 + 0x80), &except_vec3_generic, 0x80);

Eeek, will fix.  Consider the switch gone however.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>