linux-mips
[Top] [All Lists]

Re: [PATCH] dec_esp.c repair mmu_sglist breakage

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [PATCH] dec_esp.c repair mmu_sglist breakage
From: Florian Lohoff <flo@rfc822.org>
Date: Sat, 28 Sep 2002 22:19:58 +0200
Cc: Karsten Merker <karsten@excalibur.cologne.de>, linux-mips@linux-mips.org
In-reply-to: <Pine.GSO.3.96.1020928203950.10698B-100000@delta.ds2.pg.gda.pl>
Organization: rfc822 - pure communication
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20020928103840.GA23300@linuxtag.org> <Pine.GSO.3.96.1020928203950.10698B-100000@delta.ds2.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.3.28i
On Sat, Sep 28, 2002 at 08:49:52PM +0200, Maciej W. Rozycki wrote:
> On Sat, 28 Sep 2002, Karsten Merker wrote:
> 
> > > through the whole issue of the mmu_sglist confusion and the broken
> > > reimplantation of mmu_sglist the dec_esp broke. Here is a fix
> > > to really remove the mmu_sglist and use scatterlist instead. With
> > > this the Decstation on this desk at least finds its partitions
> > > again and does not crash.
> > 
> > I tested the patch on my DS 5000/150 and it works there, too.
> 
>  Thanks for the report -- since I have no means to test the SCSI driver I
> was going to ask people for testing to have another confirmation.  I'm not
> sure why it got broken (I'll check the details to find out) as the changes
> were to revert to the original behaviour, but since struct mmu_sglist got

It wasnt reverted - The problem was that the original Framework NCR53C9x
and dec_esp.c used the different structs which were not the same (Order
changed) after the change so it broke.

> deprecated, I'm happy to see an update to struct scatterlist.  Since the
> change works for both of you, I'm checking it in now. 

Flo
-- 
Florian Lohoff                  flo@rfc822.org             +49-5201-669912
                        Heisenberg may have been here.

Attachment: pgpxDUGqDOUSM.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>