linux-mips
[Top] [All Lists]

ELF32 problem in mips64 kernel

To: linux-mips@linux-mips.org
Subject: ELF32 problem in mips64 kernel
From: "Kip Walker" <kwalker@broadcom.com>
Date: Wed, 18 Sep 2002 14:29:06 -0700
Organization: Broadcom Corp. BPBU
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
There is a faulty check in include/asm-mips64/elf.h:

in elf_check_arch, the following access to the "e_flags" field is
non-sensical if the binary is ELFCLASS32, because "__h" is typed as an
elf64_hdr (through the elfhdr #define), whose e_flags is in a different
location from an elf32_hdr.

        if ((__h->e_ident[EI_CLASS] == ELFCLASS32) &&     \
            ((__h->e_flags & EF_MIPS_ABI2) == 0))         \
                __res = 0;                                \

Should the n32 check (is this what the EF_MIPS_ABI2 check is about?) be
punted to another binary format handler?  The attached patch removed the
ABI2 check.

Kip
Index: include/asm-mips64/elf.h
===================================================================
RCS file: /cvs/linux/include/asm-mips64/elf.h,v
retrieving revision 1.10.2.2
diff -u -r1.10.2.2 elf.h
--- include/asm-mips64/elf.h    2002/08/20 18:42:37     1.10.2.2
+++ include/asm-mips64/elf.h    2002/09/18 21:19:42
@@ -43,8 +43,7 @@
                                                                        \
        if (__h->e_machine != EM_MIPS)                                  \
                __res = 0;                                              \
-       if ((__h->e_ident[EI_CLASS] == ELFCLASS32) &&                   \
-           ((__h->e_flags & EF_MIPS_ABI2) == 0))                       \
+       if (__h->e_ident[EI_CLASS] == ELFCLASS32)                       \
                __res = 0;                                              \
                                                                        \
        __res;                                                          \
@@ -53,7 +52,8 @@
 /*
  * These are used to set parameters in the core dumps.
  */
-#define ELF_CLASS      ELFCLASS64
+//#define ELF_CLASS    ELFCLASS64
+#define ELF_CLASS      ELFCLASS32
 #ifdef __MIPSEB__
 #define ELF_DATA       ELFDATA2MSB
 #elif __MIPSEL__
<Prev in Thread] Current Thread [Next in Thread>