linux-mips
[Top] [All Lists]

pci_unmap_single - 2.5 kernel

To: Linux-MIPS <linux-mips@linux-mips.org>
Subject: pci_unmap_single - 2.5 kernel
From: Brian Murphy <brian@murphy.dk>
Date: Wed, 18 Sep 2002 23:14:07 +0200
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020623 Debian/1.0.0-0.woody.1
In the 2.5 kernel pci_map_sg contains these lines:

               addr = (unsigned long) page_address(sg->page);
               if (addr)
                       dma_cache_wback_inv(addr, sg->length);

Surely when flushing the offset needs to be added to the page base
address (addr)? So that this reads:

               if (addr)
                       dma_cache_wback_inv(addr + sg->offset, sg->length);


/Brian


<Prev in Thread] Current Thread [Next in Thread>
  • pci_unmap_single - 2.5 kernel, Brian Murphy <=