linux-mips
[Top] [All Lists]

Re: memcpy.S patch in 64-bit

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: memcpy.S patch in 64-bit
From: Carsten Langgaard <carstenl@mips.com>
Date: Thu, 08 Aug 2002 22:05:23 +0200
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
Organization: MIPS Technologies
References: <Pine.GSO.3.96.1020808170518.13783D-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
"Maciej W. Rozycki" wrote:

> On Thu, 8 Aug 2002, Carsten Langgaard wrote:
>
> > The __copy_user function (in arch/mips64/lib/memcpy.S) calls __bzero.
> > We can't do that because __bzero might modify len, which we want to
> > return in case of an error.
> > The following patch take care of the problem.
>
>  Hmm, how about simply cloning arch/mips/lib/memcpy.S?  It seems:
>
> 1. Designed to work on mips64 as well.
>
> 2. More up to date.
>
> And it would ease maintenance.
>

If it works then it's the right thing to do, so please go a head :-)


>
> --
> +  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
> +--------------------------------------------------------------+
> +        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>