linux-mips
[Top] [All Lists]

Re: memcpy.S patch in 64-bit

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: memcpy.S patch in 64-bit
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Thu, 8 Aug 2002 17:42:46 +0200
Cc: Carsten Langgaard <carstenl@mips.com>, linux-mips@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1020808170518.13783D-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Thu, Aug 08, 2002 at 05:08:07PM +0200
References: <3D52711F.D5C6A8FC@mips.com> <Pine.GSO.3.96.1020808170518.13783D-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5.1i
On Thu, Aug 08, 2002 at 05:08:07PM +0200, Maciej W. Rozycki wrote:

> > The __copy_user function (in arch/mips64/lib/memcpy.S) calls __bzero.
> > We can't do that because __bzero might modify len, which we want to
> > return in case of an error.
> > The following patch take care of the problem.
> 
>  Hmm, how about simply cloning arch/mips/lib/memcpy.S?  It seems:
> 
> 1. Designed to work on mips64 as well.
> 
> 2. More up to date.
> 
> And it would ease maintenance. 

Right but Carsten's patch is already ready, so I'm going to use it
for now.

  Ralf


<Prev in Thread] Current Thread [Next in Thread>