linux-mips
[Top] [All Lists]

Re: IPC syscall fixup (o32 conversion layer)

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: IPC syscall fixup (o32 conversion layer)
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Wed, 7 Aug 2002 16:58:32 +0200 (MET DST)
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
In-reply-to: <3D5131C7.17F9E00@mips.com>
Organization: Technical University of Gdansk
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
On Wed, 7 Aug 2002, Carsten Langgaard wrote:

> Here is a patch that fixes the ipc syscalls in the o32
> wrapper/conversion routines.
> Needed when running a 64-bit kernel on an o32 userland.

 Hmm, this looks dubious:

+#define AA(__x) ((unsigned long)((int)__x))

You probably want either:

((unsigned long)((unsigned int)__x))

or

((long)((int)__x)).

Since you are using pointers, likely the latter. 

 Sending patches within a mail's body would ease commenting them, BTW.  I
had to copy and paste the line above manually -- with gpm it's not a big
problem for a single line, but it gets tedious for larger chunks and gpm
is not everywhere. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>