linux-mips
[Top] [All Lists]

Re: [patch] 2.4: Revert interface removal

To: Ralf Baechle <ralf@oss.sgi.com>, "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>, linux-mips@oss.sgi.com
Subject: Re: [patch] 2.4: Revert interface removal
From: Carsten Langgaard <carstenl@mips.com>
Date: Mon, 05 Aug 2002 13:53:39 +0200
References: <Pine.GSO.3.96.1020805105624.18894C-100000@delta.ds2.pg.gda.pl> <20020805124154.B6365@dea.linux-mips.net> <3D4E5BFE.595DA175@mips.com>
Sender: owner-linux-mips@oss.sgi.com
Ralf, could we please revert the latest changes to 
include/asm-mips/scatterlist.h
and include/asm-mips/pci.h

/Carsten


Carsten Langgaard wrote:

> Changing the scatterlist and the pci functions seems to break things in the 
> IDE
> interface.
>
> /Carsten
>
> Ralf Baechle wrote:
>
> > On Mon, Aug 05, 2002 at 11:05:40AM +0200, Maciej W. Rozycki wrote:
> >
> > >  A recent change to include/asm-mips/scatterlist.h broke
> > > drivers/scsi/dec_esp.c.  Since 2.4.19 is not the proper version to remove
> > > interfaces, I'm going to check in the following patch to the 2.4 branch to
> > > revert the change (with a slightly sanitized type for the dvma_address
> > > member).
> > >
> > >  Any objections?
> >
> > Sorry for simply removing the structure, that was an accident.  The
> > question why the use of struct mmu_sglist still hasn't been replaced by
> > newer interfaces stays ...
> >
> > So please go ahead and commit your patch.
> >
> >   Ralf
>
> --
> _    _ ____  ___   Carsten Langgaard  Mailto:carstenl@mips.com
> |\  /|||___)(___   MIPS Denmark        Direct: +45 4486 5527
> | \/ |||    ____)  Lautrupvang 4B      Switch: +45 4486 5555
>   TECHNOLOGIES     2750 Ballerup       Fax...: +45 4486 5556
>                    Denmark            http://www.mips.com

--
_    _ ____  ___   Carsten Langgaard   Mailto:carstenl@mips.com
|\  /|||___)(___   MIPS Denmark        Direct: +45 4486 5527
| \/ |||    ____)  Lautrupvang 4B      Switch: +45 4486 5555
  TECHNOLOGIES     2750 Ballerup       Fax...: +45 4486 5556
                   Denmark             http://www.mips.com




<Prev in Thread] Current Thread [Next in Thread>