Re: [patch] Oops and magic SysRq stack dump clean-ups

[Johannes Stezenbach <js@convergence.de>]

On Mon, Jul 29, 2002 at 03:25:53PM +0200, Maciej W. Rozycki wrote:
>  I've reviewed the stack dumping code more thoroughly and here is the
> result.  Please check if it's OK for you.  Tested visually with oopses and
> <SysRq>+<t> on MIPS/Linux and MIPS64/Linux.  The idea is to fit as much
> data as possible in as little space as possible and at the same time lay
> the numbers out visually nicely so that manual copying of output from a
> terminal for ksymoops analysis is easier for a reader.  Tools ignore
> spacing when processing such output anyway.
> 
>  Based somewhat on the i386 port.  Addresses cast to signed longs, since
> they are such on MIPS (additionally, the code doesn't care anyway but the
> resulting source is smaller).  Any objections? 

Nope, patch and its output look good to me.


Johannes