linux-mips
[Top] [All Lists]

Re: [patch] Oops and magic SysRq stack dump clean-ups

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [patch] Oops and magic SysRq stack dump clean-ups
From: Johannes Stezenbach <js@convergence.de>
Date: Mon, 29 Jul 2002 18:02:48 +0200
Cc: Ralf Baechle <ralf@uni-koblenz.de>, linux-mips@fnet.fr, linux-mips@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1020729150226.22288D-100000@delta.ds2.pg.gda.pl>
Mail-followup-to: Johannes Stezenbach <js@convergence.de>, "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>, Ralf Baechle <ralf@uni-koblenz.de>, linux-mips@fnet.fr, linux-mips@oss.sgi.com
References: <Pine.GSO.3.96.1020725114648.27463B-100000@delta.ds2.pg.gda.pl> <Pine.GSO.3.96.1020729150226.22288D-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.4i
On Mon, Jul 29, 2002 at 03:25:53PM +0200, Maciej W. Rozycki wrote:
>  I've reviewed the stack dumping code more thoroughly and here is the
> result.  Please check if it's OK for you.  Tested visually with oopses and
> <SysRq>+<t> on MIPS/Linux and MIPS64/Linux.  The idea is to fit as much
> data as possible in as little space as possible and at the same time lay
> the numbers out visually nicely so that manual copying of output from a
> terminal for ksymoops analysis is easier for a reader.  Tools ignore
> spacing when processing such output anyway.
> 
>  Based somewhat on the i386 port.  Addresses cast to signed longs, since
> they are such on MIPS (additionally, the code doesn't care anyway but the
> resulting source is smaller).  Any objections? 

Nope, patch and its output look good to me.


Johannes


<Prev in Thread] Current Thread [Next in Thread>