linux-mips
[Top] [All Lists]

Re: sys32_execve fix

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: sys32_execve fix
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Mon, 22 Jul 2002 18:56:42 +0200 (MET DST)
Cc: Ralf Baechle <ralf@uni-koblenz.de>, linux-mips@oss.sgi.com
In-reply-to: <3D3C0E26.676F4799@mips.com>
Organization: Technical University of Gdansk
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
On Mon, 22 Jul 2002, Carsten Langgaard wrote:

> The problem is that "nargs" in arch/mips64/kernel/linux32.c fails when
> argv is NULL, the patch below should fix the problem:

 How about just:

        if (!arg)
                return 0;

at the top?  Gcc should optimize it to a single branch, likely not taken,
and a register move.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>