linux-mips
[Top] [All Lists]

Re: PATCH: Add sys/personality (Re: Personality)

To: "H. J. Lu" <hjl@lucon.org>
Subject: Re: PATCH: Add sys/personality (Re: Personality)
From: Carsten Langgaard <carstenl@mips.com>
Date: Tue, 16 Jul 2002 21:16:48 +0200
Cc: Ralf Baechle <ralf@oss.sgi.com>, GNU C Library <libc-alpha@sources.redhat.com>, linux-mips@oss.sgi.com
Organization: MIPS Technologies
References: <3D33DAB2.353A4399@mips.com> <20020716123632.B17038@dea.linux-mips.net> <20020716090728.A22128@lucon.org>
Sender: owner-linux-mips@oss.sgi.com
Thanks.
Now that we are at it, what should personality return in case it's called with a
value, which isn't defined in the personality.h file.
Should it return -EINVAL ?
I don't think, that is the case at the moment, I believe you can set personality
to anything.

/Carsten


"H. J. Lu" wrote:

> On Tue, Jul 16, 2002 at 12:36:32PM +0200, Ralf Baechle wrote:
> > On Tue, Jul 16, 2002 at 10:34:58AM +0200, Carsten Langgaard wrote:
> >
> > > The include/linux/personality.h file has changed between the 2.4.3 and
> > > the 2.4.18 kernel.
> > > Now there is a define of personality (#define personality(pers) (pers &
> > > PER_MASK), but that breaks things for the users, if they include this
> > > file.
> > > The user wishes to call the glibc personality function (which do the
> > > syscall), and not use the above definition.
> > >
> > > So I guess we need a "#ifdef __KERNEL__" around some of the code in
> > > include/linux/personality.h (at least around the define of personality),
> > > which then has to go into the glibc kernel header files.
> >
> > The general policy about such problems is to not use kernel include files
> > from user applications directly.  Hjl - maybe time for <sys/personality.h>?
> >
>
> Here is a patch.
>
> H.J.
>
>   ------------------------------------------------------------------------
>
>    glibc-personality.patchName: glibc-personality.patch
>                           Type: Plain Text (text/plain)


<Prev in Thread] Current Thread [Next in Thread>