linux-mips
[Top] [All Lists]

Re: PATCH

To: Ralf Baechle <ralf@oss.sgi.com>
Subject: Re: PATCH
From: Pete Popov <ppopov@mvista.com>
Date: Tue, 16 Jul 2002 08:15:56 -0700
Cc: linux-mips <linux-mips@oss.sgi.com>
In-reply-to: <20020716170741.E31186@dea.linux-mips.net>
References: <1026772150.15665.145.camel@zeus.mvista.com> <20020716170741.E31186@dea.linux-mips.net>
Sender: owner-linux-mips@oss.sgi.com
On Tue, 2002-07-16 at 08:07, Ralf Baechle wrote:
> On Mon, Jul 15, 2002 at 03:29:10PM -0700, Pete Popov wrote:
> 
> > --- include/asm-mips/pgtable.h.old  Fri Jul 12 17:25:19 2002
> > +++ include/asm-mips/pgtable.h      Fri Jul 12 17:25:36 2002
> > @@ -332,7 +332,9 @@
> >  
> >  static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
> >  {
> > -   return __pte(((pte).pte_low & _PAGE_CHG_MASK) | pgprot_val(newprot));
> > +   pte.pte_low &= _PAGE_CHG_MASK;
> > +   pte.pte_low |= pgprot_val(newprot);
> > +   return pte;
> >  }
> 
> This patch certainly doesn't apply to oss.  Seems somebody did copy all
> the x86 pte_t and stuff into your tree without too much thinking ...

That's right, I forgot you don't have the 36 bit code that uses pte_low
and pte_high.  

Pete


<Prev in Thread] Current Thread [Next in Thread>