linux-mips
[Top] [All Lists]

Re: [Oops] Indy R4600 Oops(es) w/ 2.4.19-rc1

To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Subject: Re: [Oops] Indy R4600 Oops(es) w/ 2.4.19-rc1
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Mon, 1 Jul 2002 16:28:13 +0200 (MET DST)
Cc: linux-mips@oss.sgi.com, Ralf Baechle <ralf@oss.sgi.com>
In-reply-to: <20020701094359.GP17216@lug-owl.de>
Organization: Technical University of Gdansk
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
On Mon, 1 Jul 2002, Jan-Benedict Glaw wrote:

> Okay, stupid idea. All these flush functions seem to be never called in
> parallel or recursive, so if might be possible to have a global flags
> variable and instead of always calling __save..() and __restore..(),
> we bulid a pair of inline functions doing this. This wouldn't give
> any penalty for !CONFIG_CPU_R4X00 and doesn't obscure the code so much
> as all those #ifdef and #endif's would do... I'll test my suggestion
> as fast as I reach my Indy again (is powered down at home...).

 Feel free to use the change privately.  Otherwise please code a real fix,
i.e. a set of buggy-R4600-specific functions, as CONFIG_CPU_R4X00 means
other processors as well, e.g. R4000 or R4400 which are fine here. 

 Actually blocking interrupts for over 0.01s as it used to be done is
unacceptable, even for buggy R4600 processors.  A fix should use a more
fine-grained interrupt masking. 

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>