linux-mips
[Top] [All Lists]

Re: [patch] linux: DBE/IBE handling rewrite

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [patch] linux: DBE/IBE handling rewrite
From: Jun Sun <jsun@mvista.com>
Date: Wed, 26 Jun 2002 10:17:28 -0700
Cc: Ladislav Michl <ladis@psi.cz>, Ralf Baechle <ralf@uni-koblenz.de>, linux-mips@oss.sgi.com
References: <Pine.GSO.3.96.1020626121553.23599A-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.2.1) Gecko/20010901

I suggest we have a function pointer called board_bus_error_init, which is initialized to a NULL function. Any board that wishes to override it can do so in <board>_setup() routine.

With more amd more MIPS boards poping up, the more friendly board interface is the better.

Jun

Maciej W. Rozycki wrote:

On Tue, 25 Jun 2002, Maciej W. Rozycki wrote:


This way, the fixup search is invoked first and a system-specific handler
can judge whether to let the fixup be invoked or a serious failure
happened and the system should act appropriately.  The handler can do
whatever actions are needed (e.g. clear error status data in system
registers, report ECC syndromes, etc.) for the system for both cases.


 OK, here is the code.  I wrote it a bit differently from what I
considered yesterday, as fixup doesn't seem useful for a system-specific
handler.  With the following code only a boolean flag is passed informing
whether a fixup is available and the handler can decide how to treat an
error, based on the state passed as arguments and possibly additional one
obtained from system-specific resources.  Both MIPS and MIPS64 are handled
in the same way.  For MIPS64 it means a removal of duplicated similar code
as well.  I adjusted some SGI-specific code appropriately, but platform
maintainers will have to check if bus_error_init() stubs are OK for them.

 Ralf, OK to apply?

  Maciej





<Prev in Thread] Current Thread [Next in Thread>