linux-mips
[Top] [All Lists]

Re: [patch] linux: DBE/IBE handling rewrite

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [patch] linux: DBE/IBE handling rewrite
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Wed, 26 Jun 2002 14:05:52 +0200
Cc: Ladislav Michl <ladis@psi.cz>, linux-mips@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1020626121553.23599A-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Wed, Jun 26, 2002 at 01:51:08PM +0200
References: <Pine.GSO.3.96.1020625131229.29623A-100000@delta.ds2.pg.gda.pl> <Pine.GSO.3.96.1020626121553.23599A-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5.1i
On Wed, Jun 26, 2002 at 01:51:08PM +0200, Maciej W. Rozycki wrote:

> >  This way, the fixup search is invoked first and a system-specific handler
> > can judge whether to let the fixup be invoked or a serious failure
> > happened and the system should act appropriately.  The handler can do
> > whatever actions are needed (e.g. clear error status data in system
> > registers, report ECC syndromes, etc.) for the system for both cases.
> 
>  OK, here is the code.  I wrote it a bit differently from what I
> considered yesterday, as fixup doesn't seem useful for a system-specific
> handler.  With the following code only a boolean flag is passed informing
> whether a fixup is available and the handler can decide how to treat an
> error, based on the state passed as arguments and possibly additional one
> obtained from system-specific resources.  Both MIPS and MIPS64 are handled
> in the same way.  For MIPS64 it means a removal of duplicated similar code
> as well.  I adjusted some SGI-specific code appropriately, but platform
> maintainers will have to check if bus_error_init() stubs are OK for them.
> 
>  Ralf, OK to apply?

Certainly looks saner than what we're having right now.  Please apply.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>