linux-mips
[Top] [All Lists]

Re: 2.4.18: pgtable.h compile fix

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: 2.4.18: pgtable.h compile fix
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Tue, 25 Jun 2002 10:54:36 +0200
Cc: Guido Guenther <agx@sigxcpu.org>, linux-mips@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1020624174346.22509N-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Mon, Jun 24, 2002 at 05:54:28PM +0200
References: <20020624153330.C28145@dea.linux-mips.net> <Pine.GSO.3.96.1020624174346.22509N-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5.1i
On Mon, Jun 24, 2002 at 05:54:28PM +0200, Maciej W. Rozycki wrote:

> > >  MIPS64 lags behind a bit due to less interest/testing.  Note that you
> > > should use "__ASSEMBLY__" to guard assembly-unsafe parts of headers.
> > 
> > _LANGUAGE_ASSEMBLY is the traditional MIPS cpp symbol to indicate assembler
> > source code.
> 
>  Well, but the rest of the kernel uses "__ASSEMBLY__", that's defined in
> the top-level Makefile.  What's the point in being different? 
> 
>  Also it doesn't seem to work for me -- the rules in specs look broken:
> 
> $ mipsel-linux-gcc -E -dM -xassembler-with-cpp /dev/null | grep LANGUAGE
> #define __LANGUAGE_C 1
> #define _LANGUAGE_C 1
> #define LANGUAGE_C 1
> 
> thus it cannot be considered reliable.

The machanism guesses the language based on the source file name extension:

[ralf@dea tmp]$ echo -n > c.c && mips-linux-gcc -E -dM -xassembler-with-cpp c.c 
| grep LANG
#define __LANGUAGE_C 1 
#define _LANGUAGE_C 1 
#define LANGUAGE_C 1 
[ralf@dea tmp]$ echo -n > c.S && mips-linux-gcc -E -dM c.S | grep LANG
#define LANGUAGE_ASSEMBLY 1 
#define _LANGUAGE_ASSEMBLY 1 
#define __LANGUAGE_ASSEMBLY 1 
[ralf@dea tmp]$

Buggy?  Yes ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>