linux-mips
[Top] [All Lists]

Re: sys_syscall patch.

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: sys_syscall patch.
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Mon, 24 Jun 2002 11:54:52 +0200
Cc: linux-mips@oss.sgi.com
In-reply-to: <3D16E14C.5C8D2FAD@mips.com>; from carstenl@mips.com on Mon, Jun 24, 2002 at 11:07:24AM +0200
References: <3D16E14C.5C8D2FAD@mips.com>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5.1i
On Mon, Jun 24, 2002 at 11:07:24AM +0200, Carsten Langgaard wrote:

> The 'sys_syscall' syscall isn't properly implemented in the 64-bit
> kernel (for o32 as well as n64).
> Below is a patch, it seems to work for in the o32 case, but I haven't
> tested the n64 version (obviously).

> +/*
> + * Do the indirect syscall syscall.
> + * Don't care about kernel locking; the actual syscall will do it.
> + *
> + * XXX This is broken.
> + */

As the comment says - it's broken.  This implementation just like it's
32-bit predecessor don't handle the error return value correctly.  Worse,
there's unprotected accesses to userspace which allow any user crashing
the system ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>