linux-mips
[Top] [All Lists]

Re: system.h asm fixes

To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Subject: Re: system.h asm fixes
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Tue, 18 Jun 2002 02:52:04 +0200
Cc: linux-mips@oss.sgi.com
In-reply-to: <20020617223650.GD20335@rembrandt.csv.ica.uni-stuttgart.de>; from ica2_ts@csv.ica.uni-stuttgart.de on Tue, Jun 18, 2002 at 12:36:50AM +0200
References: <1024338042.1463.21.camel@localhost.localdomain> <20020617224452.C27009@dea.linux-mips.net> <20020617223650.GD20335@rembrandt.csv.ica.uni-stuttgart.de>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5.1i
On Tue, Jun 18, 2002 at 12:36:50AM +0200, Thiemo Seufer wrote:

> Ralf Baechle wrote:
> [snip]
> > > Looks to me like we're missing some proper asm clobber markers:
> > 
> > No, as per convention $1 is never used by the compiler per convention,
> > so clobbering not necessary.  I recently removed all "$1" clobbers to
> > make the code a bit easier to read.
> 
> How can this work? A grep shows many instances of $1 usage,

Uses by assembler code only, not gcc.  Therefoe we don't need to protect
C code against use of $at.

> I don't think all of this code is interrupt safe.

How this should relate to interrupts is beyond me.  Exception handlers do
their own register saving thing.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>