| To: | saw@saw.sw.com.sg |
|---|---|
| Subject: | Re: NAPI for eepro100 |
| From: | "David S. Miller" <davem@redhat.com> |
| Date: | Thu, 13 Jun 2002 01:47:00 -0700 (PDT) |
| Cc: | fxzhang@ict.ac.cn, linux-mips@oss.sgi.com, linux-kernel@vger.kernel.org, netdev@oss.sgi.com, jgarzik@mandrakesoft.com |
| In-reply-to: | <20020613125753.A23693@castle.nmd.msu.ru> |
| References: | <3D07D270.5060902@mandrakesoft.com> <20020612.160532.134201977.davem@redhat.com> <20020613125753.A23693@castle.nmd.msu.ru> |
| Sender: | owner-linux-mips@oss.sgi.com |
From: Andrey Savochkin <saw@saw.sw.com.sg> Date: Thu, 13 Jun 2002 12:57:53 +0400 On Wed, Jun 12, 2002 at 04:05:32PM -0700, David S. Miller wrote: > No, it's worse than that. > > See how non-consistent memory is used by the eepro100 driver > for descriptor bits? The skb->tail bits? > > That is very problematic. What's the problem? If it isn't allowed to do, then what is the meaning of PCI_DMA_BIDIRECTIONAL mappings? It's slow. Not wrong, just inefficient. Descriptors were meant to be done using consistent mappings, not "pci_map_*()"'d memory. The latter is meant to be used for long linear DMA transfers to/from the device. It is not meant for things the cpu pokes small bits of data in and out of, that is what consistent DMA memory is for. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: NAPI for eepro100, Andrey Savochkin |
|---|---|
| Next by Date: | [RFC and PATCH] Move the m68k genrtc driver into 2.5 and use on PPC, Tom Rini |
| Previous by Thread: | Re: NAPI for eepro100, Andrey Savochkin |
| Next by Thread: | Falls du Kinder hast - wichtig! Gegen Gewalt am Computer!, xcd4u |
| Indexes: | [Date] [Thread] [Top] [All Lists] |