linux-mips
[Top] [All Lists]

Re: [patch] linux: mb() and friends again

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [patch] linux: mb() and friends again
From: "Gleb O. Raiko" <raiko@niisi.msk.ru>
Date: Tue, 04 Jun 2002 15:42:08 +0400
Cc: Ralf Baechle <ralf@uni-koblenz.de>, linux-mips@fnet.fr, linux-mips@oss.sgi.com
Organization: NIISI RAN
References: <Pine.GSO.3.96.1020603182621.14451E-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
Maciej,

In previous version of your patch there was the change in mm/c-r3k.c:

static void r3k_dma_cache_wback_inv(unsigned long start, unsigned long
size)
{
-       wbflush();
+       iob();
        r3k_flush_dcache_range(start, start + size);
}

Why did you drop it? It's definetely required.

While you patch operates in unusual terms from hw point of view, it does
right thins by stating that external wbs do differ from internal wb.

Regards,
Gleb.

Ah. The patch shall be applied, certainly.

<Prev in Thread] Current Thread [Next in Thread>