linux-mips
[Top] [All Lists]

Re: linux.h patch for mips

To: "H . J . Lu" <hjl@lucon.org>
Subject: Re: linux.h patch for mips
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Sat, 25 May 2002 20:14:04 +0200
Cc: Eric Christopher <echristo@redhat.com>, cgd@broadcom.com, linux-mips@oss.sgi.com
In-reply-to: <20020524190322.C10735@lucon.org>
References: <1022278283.25829.46.camel@ghostwheel.cygnus.com> <20020524190322.C10735@lucon.org>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.3.28i
H . J . Lu wrote:
> I will leave it to the Linux mips people. Any comments?
> 
> 
> H.J.
> ---
> On Fri, May 24, 2002 at 03:11:23PM -0700, Eric Christopher wrote:
> > Hey, wanted to run this by you.
> > 
> > I've noticed a tendency for the linux kernel people to test
> > _MIPS_ISA_MIPSXX when writing defines for 32 v. 64 bit code in the asm
> > headers (and other places). Personally I'd prefer they check something
> > else like -D__mips_fpr=32/64, but it's not something I have time to fix
> > in the kernel right now (and for gpr I'd have to define something new,
> > which wouldn't be hard).
> > 
> > Thought I'd check with you and see if you had any other ideas how better
> > to do that kind of interface?
> > 
> > -eric
> > 
> > ps. I'm checking the following patch in momentarily to fix a problem I
> > noticed.
> > 
> > -- 
> > I will not carve gods
> > 
> > Index: linux.h
> > ===================================================================
> > RCS file: /cvs/gcc/gcc/gcc/config/mips/linux.h,v
> > retrieving revision 1.44
> > diff -u -p -w -r1.44 linux.h
> > --- linux.h 20 May 2002 17:11:53 -0000      1.44
> > +++ linux.h 24 May 2002 21:56:01 -0000
> > @@ -155,6 +155,8 @@ void FN ()                                              
> >         \
> >  %{mips2: -D_MIPS_ISA=_MIPS_ISA_MIPS2} \
> >  %{mips3: -D_MIPS_ISA=_MIPS_ISA_MIPS3} \
> >  %{mips4: -D_MIPS_ISA=_MIPS_ISA_MIPS4} \

At least for completeness there should be also _MIPS_ISA_MIPS5
(the -mips5 swich would cause _MIPS_ISA_MIPS1 otherwise).

> > +%{mips32: -D_MIPS_ISA=_MIPS_ISA_MIPS32} \
> > +%{mips64: -D_MIPS_ISA=_MIPS_ISA_MIPS64} \
> >  %{!mips*: -D_MIPS_ISA=_MIPS_ISA_MIPS1} \
> >  %{mabi=32: -D_MIPS_SIM=_MIPS_SIM_ABI32}    \
> >  %{mabi=n32: -D_ABIN32=2 -D_MIPS_SIM=_ABIN32} \

<Prev in Thread] Current Thread [Next in Thread>