linux-mips
[Top] [All Lists]

Re: what is the right behavior of copy_to_user(0x0, ..., ...)?

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: what is the right behavior of copy_to_user(0x0, ..., ...)?
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Tue, 7 May 2002 01:53:13 +0800
Cc: Jun Sun <jsun@mvista.com>, linux-mips <linux-mips@oss.sgi.com>
In-reply-to: <3CD794BC.43264E9E@mips.com>; from carstenl@mips.com on Tue, May 07, 2002 at 10:47:56AM +0200
References: <3CD3052B.1050400@mvista.com> <20020503162337.A27366@dea.linux-mips.net> <3CD32044.9040109@mvista.com> <20020503184000.A1238@dea.linux-mips.net> <3CD794BC.43264E9E@mips.com>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Tue, May 07, 2002 at 10:47:56AM +0200, Carsten Langgaard wrote:

> It fix a problem I have had for quite a while in the r4k_fpu.S. The code in
> question is:
>         jr      ra
>         .set    nomacro
>          EX(sw  t0,SC_FPC_EIR(a0))
>         .set    macro
> 
> I have fixed it locally by removing the SW from the delay-slot, but obviously
> your fix is the right one.
> But I guess we need the same fix in arch/mips/kernel/unaligned.c.

Good spotting.  I'll use a slightly different fix using the new inline
function exception_epc() in <asm/branch.h> to implement that slightly
more elegant.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>