linux-mips
[Top] [All Lists]

Re: Does e2fsprogs-1.26 work on mips?

To: Theodore Tso <tytso@mit.edu>
Subject: Re: Does e2fsprogs-1.26 work on mips?
From: Paul Mackerras <paulus@samba.org>
Date: Tue, 26 Mar 2002 21:51:56 +1100 (EST)
Cc: Andrew Morton <akpm@zip.com.au>, "H . J . Lu" <hjl@lucon.org>, linux-mips@oss.sgi.com, linux kernel <linux-kernel@vger.kernel.org>, GNU C Library <libc-alpha@sources.redhat.com>
In-reply-to: <20020326015440.A12162@thunk.org>
References: <20020323140728.A4306@lucon.org> <3C9D1C1D.E30B9B4B@zip.com.au> <20020323221627.A10953@lucon.org> <3C9D7A42.B106C62D@zip.com.au> <20020324012819.A13155@lucon.org> <20020325003159.A2340@thunk.org> <3C9EB8F6.247C7C3B@zip.com.au> <20020326015440.A12162@thunk.org>
Reply-to: paulus@samba.org
Sender: owner-linux-mips@oss.sgi.com
Theodore Tso writes:

> 3)  RLIMIT_FILESIZE should not apply to block devices!!!

Absolutely.

I would go further and say that it should only apply to writes to a
regular file that would extend the file past the filesize limit.  At
the moment the check in generic_file_write is simply whether the file
offset is greater than the limit, or would be greater than the limit
after the write.  This doesn't seem right to me.  If, for example, my
RLIMIT_FILESIZE is 1MB, and I have write access to an existing 100MB
file, I think I should be able to write anywhere in that file as long
as I don't try to extend it.

If we did that then the block device case would fall out, since you
can't extend block devices (not by writing past the end of them
anyway).

Paul.

<Prev in Thread] Current Thread [Next in Thread>