linux-mips
[Top] [All Lists]

Re: ip22 watchdog timer

To: Guido Guenther <agx@sigxcpu.org>
Subject: Re: ip22 watchdog timer
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Fri, 15 Feb 2002 15:17:17 +0100 (MET)
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
In-reply-to: <20020215130613.A301@gandalf.physik.uni-konstanz.de>
Organization: Technical University of Gdansk
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
On Fri, 15 Feb 2002, Guido Guenther wrote:

> diff --exclude=CVS -Naur linux-2.4.17.orig/drivers/char/Config.in
> linux-2.4.17/drivers/char/Config.in
> --- linux-2.4.17.orig/drivers/char/Config.in    Sun Dec  2 12:34:40 2001
> +++ linux-2.4.17/drivers/char/Config.in Fri Feb 15 10:00:59 2002
> @@ -199,6 +199,7 @@
>     tristate '  SBC-60XX Watchdog Timer' CONFIG_60XX_WDT
>     tristate '  W83877F (EMACS) Watchdog Timer' CONFIG_W83877F_WDT
>     tristate '  ZF MachZ Watchdog' CONFIG_MACHZ_WDT
> +   tristate '  Indy/I2 Hardware Watchdog' CONFIG_INDYDOG
>  fi
>  endmenu

 This looks suspicious.  Haven't you meant "dep_tristate"?  Especially as
indydog.c doesn't seem to make any effort to validate it's running on the
system it thinks it is before poking random memory locations.  It won't
probably even compile for a non-MIPS kernel.

 BTW, why do people insist on sending patches as attachments -- it makes
commenting them helly twisted, sigh... 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>