linux-mips
[Top] [All Lists]

Re: [PATCH] Eliminate more compiler warnings...

To: "Steven J. Hill" <sjhill@cotw.com>
Subject: Re: [PATCH] Eliminate more compiler warnings...
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 7 Feb 2002 17:18:30 +0100 (MET)
Cc: ralf@oss.sgi.com, linux-mips@oss.sgi.com
In-reply-to: <3C62A3D5.C9F7808E@cotw.com>
Organization: Technical University of Gdansk
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
On Thu, 7 Feb 2002, Steven J. Hill wrote:

> Please apply this too. Thanks.
[...]
>         printk("%s at 0x%03x-0x%03x,0x%03x on irq %d", hwif->name,
> -               hwif->io_ports[IDE_DATA_OFFSET],
> -               hwif->io_ports[IDE_DATA_OFFSET]+7,
> -               hwif->io_ports[IDE_CONTROL_OFFSET], hwif->irq);
> +               (unsigned int) hwif->io_ports[IDE_DATA_OFFSET],
> +               (unsigned int) hwif->io_ports[IDE_DATA_OFFSET]+7,
> +               (unsigned int) hwif->io_ports[IDE_CONTROL_OFFSET], hwif->irq);

 Why is it needed?  hwif->io_ports[...] or ide_ioreg_t is short which gets
promoted to int due to varargs automatically. 

 BTW, please send patches to the list as inlined plain text if possible. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>