linux-mips
[Top] [All Lists]

Re: PATCH: Fix ll/sc for mips

To: "H . J . Lu" <hjl@lucon.org>
Subject: Re: PATCH: Fix ll/sc for mips
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 31 Jan 2002 23:17:21 +0100 (MET)
Cc: GNU C Library <libc-alpha@sources.redhat.com>, linux-mips@oss.sgi.com
In-reply-to: <20020131123547.A22759@lucon.org>
Organization: Technical University of Gdansk
Sender: owner-linux-mips@oss.sgi.com
On Thu, 31 Jan 2002, H . J . Lu wrote:

>       (__compare_and_swap): Return 0 when failed to compare or swap.
[...]
>       * sysdeps/mips/atomicity.h (compare_and_swap): Return 0 when
>       failed to compare or swap.

 Looking at the i486 implementation these are not expected to fail. 
Unless I am missing something... 

>       * sysdeps/unix/sysv/linux/mips/sys/tas.h (_test_and_set): Fill
>       the delay slot.

 What's the difference?  The code looks the same after changes.  Also you
forgot to indent instructions in delay slots, which worsens readability. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>