Re: PATCH: Fix ll/sc for mips

["Maciej W. Rozycki" <macro@ds2.pg.gda.pl>]

On Thu, 31 Jan 2002, H . J . Lu wrote:

>       (__compare_and_swap): Return 0 when failed to compare or swap.
[...]
>       * sysdeps/mips/atomicity.h (compare_and_swap): Return 0 when
>       failed to compare or swap.

 Looking at the i486 implementation these are not expected to fail. 
Unless I am missing something... 

>       * sysdeps/unix/sysv/linux/mips/sys/tas.h (_test_and_set): Fill
>       the delay slot.

 What's the difference?  The code looks the same after changes.  Also you
forgot to indent instructions in delay slots, which worsens readability. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +