linux-mips
[Top] [All Lists]

Re: pgd_init() Patch

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: pgd_init() Patch
From: Pete Popov <ppopov@pacbell.net>
Date: 28 Jan 2002 12:03:19 -0800
Cc: Phil Thompson <phil@river-bank.demon.co.uk>, Linux/MIPS Development <linux-mips@oss.sgi.com>
In-reply-to: <Pine.GSO.4.21.0201282052240.2836-100000@vervain.sonytel.be>
References: <Pine.GSO.4.21.0201282052240.2836-100000@vervain.sonytel.be>
Sender: owner-linux-mips@oss.sgi.com
On Mon, 2002-01-28 at 11:53, Geert Uytterhoeven wrote:
> On Mon, 28 Jan 2002, Phil Thompson wrote:
> > - USER_PTRS_PER_PGD is defined as TASK_SIZE/PGDIR_SIZE. However,
> > because, TASK_SIZE is actually defined as one less that the maximum task
>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > size there is a rounding error that means that USER_PTRS_PER_PGD works
>   ^^^^
> > out at 511 rather than 512. This means that entries 511 and 1023 of
> > swapper_pg_dir don't get initialised.
> > 
> > The corresponding mips64 code has only the first call to pgd_init() and
> > each implementation of pgd_init() initialises PTRS_PER_PGD entries,
> > where PTRS_PER_PGD is simple defined as 1024.
> > 
> > The attached patch applies the mips64 approach to the mips code.
> > 
> > Should USER_PTRS_PER_PGD be defined as (TASK_SIZE/PGDIR_SIZE) + 1?
> 
> You mean ((TASK_SIZE)+1)/PGDIR_SIZE?

Or how about:

#define USER_PTRS_PER_PGD      ((TASK_SIZE-1)/PGDIR_SIZE + 1)


The above patch fixes a rather serious memory leak.  When a parent
process forks a large number of children and then it exits before the
children exit, we lose one page per child. I was able to narrow down the
problem and reproduce it with the attached program.  Ralf has the fix,
but was examining related issues before applying the patch.

Pete

Attachment: mleak.c
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>