linux-mips
[Top] [All Lists]

Re: patches for test-and-set without ll/sc (Re: thread-ready ABIs)

To: Machida Hiroyuki <machida@sm.sony.co.jp>
Subject: Re: patches for test-and-set without ll/sc (Re: thread-ready ABIs)
From: Ulrich Drepper <drepper@redhat.com>
Date: 21 Jan 2002 22:37:02 -0800
Cc: kevink@mips.com, hjl@lucon.org, libc-hacker@sources.redhat.com, linux-mips@oss.sgi.com
In-reply-to: <20020122152744C.machida@sm.sony.co.jp>
References: <20020120193843M.machida@sm.sony.co.jp> <002c01c1a1a9$b9f0de40$0deca8c0@Ulysses> <20020120221607T.machida@sm.sony.co.jp> <20020122152744C.machida@sm.sony.co.jp>
Reply-to: drepper@redhat.com (Ulrich Drepper)
Sender: owner-linux-mips@oss.sgi.com
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.5 (asparagus)
Machida Hiroyuki <machida@sm.sony.co.jp> writes:

>   * glibc change:
> 
>       We implement  test_and_set(addr, val) as follows,
> 
>               Do mmap /dev/tst to _TST_START_MAGIC, if not yet mapped.
>               call _TST_START_MAGIC(addr, val)
>       
>       If we can't open /dev/tst then, use sysmips() as final resort.

First, the patch as it is unacceptable.  A file with copyright Sony?
All the code must be copyrighted by the FSF.  Sony will have to assign
the copyright for the code to the FSF.

Also, no such change can be accepted until the necessary kernel
changes are in the official kernel sources.  I cannot make any
exceptions since otherwise all kinds of people want to see support for
their local hack added.

Furthermore, the symbols were not available in version 2.2.  Therefore
they cannot be exported with this version.  It'll either be 2.2.6 (if
their ever will be such a release) or 2.3.

And finally, the patch should be sent to the glibc MIPS maintainer for
review.  The question is who feels responsible...

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

<Prev in Thread] Current Thread [Next in Thread>