linux-mips
[Top] [All Lists]

Re: IDE driver broken in bigendian 2.4.17 kernel

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: IDE driver broken in bigendian 2.4.17 kernel
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Fri, 18 Jan 2002 12:16:14 +0100 (MET)
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
In-reply-to: <3C472F60.E5B62F0C@mips.com>
Organization: Technical University of Gdansk
Sender: owner-linux-mips@oss.sgi.com
On Thu, 17 Jan 2002, Carsten Langgaard wrote:

> The order of header inclusions doesn't matter, because the ide.h file include 
> the
> io.h file, and that way io.h always get include first.
> The '#ifndef' in all header file makes sure it only get included once.

 Then it's partially safe -- the definition used still depends on whether
some code includes ide.h or not.

> >  If the problem is generic to a chipset, then you indeed need to redefine
> > I/O macros, but then in <asm/io.h>.  If that's PCI-specific, for example,
> > then you should probably make the redefinition conditional on CONFIG_PCI.
> 
> I'm not in a position, where I can fix and not at least test the changes, 
> that it
> needed in both the IDE driver as well as in all the other bigendian 
> architectures
> ide.h files.

 Nobody expects you to test changes on every possible system in existence. 
Just try to handle whatever you anticipate and let people test the
changes.  You can read the code and see what others expect from it -- most
likely that will be accurate or you hit a comment on why something is not
obvious. 

> I think my fix is the only one that doesn't break things for anyone else, you 
> may
> argue that it isn't the right one and I kind of agree, but at this point I 
> think
> it's the best solution.

 I'm afraid it is the kind of a defensive attitude that makes the
arch/mips, include/asm-mips code so ugly and hackish in certain places. 
The discussion lists (linux-mips, linux-kernel and others, depending on
the subsystem) exist for the purpose to send patches and let people test
them.  You need not be afraid something gets broken -- it happens all the
time -- if anyone uses the code affected, someone will fix it, otherwise
why to care at all? 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>