linux-mips
[Top] [All Lists]

Re: IDE driver broken in bigendian 2.4.17 kernel

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: IDE driver broken in bigendian 2.4.17 kernel
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 17 Jan 2002 16:31:02 +0100 (MET)
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
In-reply-to: <3C46D248.931FB659@mips.com>
Organization: Technical University of Gdansk
Sender: owner-linux-mips@oss.sgi.com
On Thu, 17 Jan 2002, Carsten Langgaard wrote:

> One could argue that the IDE driver should use it's own special functions
> (like ide_insl, etc ...) and not use the generic functions (insl, etc ...).

 If it's due to a problem with an IDE host adapter then it should be fixed
within the IDE driver (or not at all and kept privately as needed).  In no
case the order of header inclusions may determine function or macro
definitions. 

> But all other architectures does it this way, so I'm just trying to follow
> the trend.

 It does not mean other architectures are right here.  Possibly they have
not hit the problem so far.

 If the problem is generic to a chipset, then you indeed need to redefine
I/O macros, but then in <asm/io.h>.  If that's PCI-specific, for example,
then you should probably make the redefinition conditional on CONFIG_PCI. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>